linux-kernel - Re: linux-next: Fixes tags need some work in the pinctrl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf90c37b-0184-845c-dd6a-c2f4a038b075@postmarketos.org>
Date:   Mon, 25 Apr 2022 13:27:35 +0100
From:   Caleb Connolly <kc@...tmarketos.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tags need some work in the pinctrl tree

Hi both,

Apologies, I made a silly mistake when submitting this series.

Patch 2 
(https://lore.kernel.org/linux-rockchip/20220328005005.72492-3-kc@postmarketos.org/), 
contains a fix which should have been squashed into patch one - the first hunk 
of the diff, the bug is a bitwise compare to an enum which isn't bitwise:

if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE))

In hindsight, I think it was a mistake the add a Fixes tag to the first patch, 
it doesn't fix a "bug" it just adds behaviour which arguably should have been 
implemented in the patch it fixes.

The patch shouldn't be backported to stable as it will introduce a bug if ported 
without the second patch (and as above, I don't think this series should be 
backported at all). Could you let me know how to get this dropped from backporting?

Again, sorry for the hassle this has caused.

Kind regards,
Caleb

On 22/04/2022 21:57, Linus Walleij wrote:
> On Thu, Apr 21, 2022 at 1:11 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
>> In commit
>>
>>    6548c9dc711d ("pinctrl/rockchip: support deferring other gpio params")
>>
>> Fixes tags
>>
>>    Fixes: e7165b1d ("pinctrl/rockchip: add a queue for deferred pin output settings on probe")
>>    Fixes: 59dd178e ("gpio/rockchip: fetch deferred output settings on probe")
>>
>> have these problem(s):
>>
>>    - SHA1 should be at least 12 digits long
>>      This can be fixed for the future by setting core.abbrev to 12 (or
>>      more) or (for git v2.11 or later) just making sure it is not set
>>      (or set to "auto").
> 
> Fixed it up by rebasing, thanks!
> 
> Yours,
> Linus Walleij