linux-kernel - Re: [PATCH v22 1/2] wireless: Initial driver submission for pureLiFi STA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <165089199642.17454.12727074837478904084.kvalo@kernel.org>
Date:   Mon, 25 Apr 2022 13:06:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Srinivasan Raju <srini.raju@...elifi.com>
Cc:     mostafa.afgani@...elifi.com,
        Srinivasan Raju <srini.raju@...elifi.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-kernel@...r.kernel.org (open list),
        linux-wireless@...r.kernel.org (open list:NETWORKING DRIVERS (WIRELESS)),
        netdev@...r.kernel.org (open list:NETWORKING DRIVERS)
Subject: Re: [PATCH v22 1/2] wireless: Initial driver submission for pureLiFi
 STA
 devices

Srinivasan Raju <srini.raju@...elifi.com> wrote:

> This driver implementation has been based on the zd1211rw driver
> 
> Driver is based on 802.11 softMAC Architecture and uses
> native 802.11 for configuration and management
> 
> The driver is compiled and tested in ARM, x86 architectures and
> compiled in powerpc architecture
> 
> Signed-off-by: Srinivasan Raju <srini.raju@...elifi.com>

While reviewing this for the last time I did some minor changes in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/commit/?h=pending&id=68d57a07bfe5bb29b80cd8b8fa24c9d1ea104124

Here's the commit log I plan to use:

    wireless: add plfxlc driver for pureLiFi X, XL, XC devices
    
    This is a driver for pureLiFi X, XL, XC devices which use light to transmit
    data, so they are not compatible with normal Wi-Fi devices. The driver uses
    separate NL80211_BAND_LC band to distinguish from Wi-Fi.  The driver is based
    on 802.11 softMAC Architecture and uses native 802.11 for configuration and
    management. Station and Ad-Hoc modes are supported.
    
    The driver is compiled and tested in ARM, x86 architectures and compiled in
    powerpc architecture. This driver implementation has been based on the zd1211rw
    driver.

And the list of changes I made:

* rewrote the commit log

* change MAINTAINER to be only for plfxlc

* CONFIG_PURELIFI_XLC -> CONFIG_PLFXLC

* purelifi_xlc.ko -> plfxlc.ko

* improve Kconfig help text

* _LF_X_CHIP_H -> PLFXLC_CHIP_H

* PURELIFI_MAC_H -> PLFXLC_MAC_H

* _PURELIFI_USB_H -> PLFXLC_USB_H

* upload_mac_and_serial() -> plfxlc_upload_mac_and_serial()

Unless I don't get any comments I'm planning to merge this on Wednesday.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220224182042.132466-3-srini.raju@purelifi.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches