linux-kernel - Re: [PATCH v3 1/5] memblock tests: update style of comments for memblock_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d80cb56-4216-2d5b-7ab5-8abd60d2871c@redhat.com>
Date:   Mon, 25 Apr 2022 15:38:58 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Rebecca Mckeever <remckee0@...il.com>, outreachy@...ts.linux.dev
Cc:     Mike Rapoport <rppt@...nel.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] memblock tests: update style of comments for
 memblock_add_*() functions

On 22.04.22 15:32, Rebecca Mckeever wrote:
> Update comments in memblock_add_*() functions to match the style used
> in tests/alloc_*.c by rewording to make the expected outcome more apparent
> and, if more than one memblock is involved, adding a visual of the
> memory blocks.
> 
> Signed-off-by: Rebecca Mckeever <remckee0@...il.com>

Please make sure to not drop Rb/Ack tags and instead carry them along
when you resend patches. This, for example,  makes it easier for
reviewers to spot what needs attention and review.

Reviewed-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb