lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Apr 2022 07:10:28 -0700 From: "David E. Box" <david.e.box@...ux.intel.com> To: Tom Rix <trix@...hat.com>, irenic.rajneesh@...il.com, david.e.box@...el.com, hdegoede@...hat.com, markgross@...nel.org Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] platform/x86/intel: pmc/core: change pmc_lpm_modes to static On Sat, 2022-04-23 at 08:30 -0400, Tom Rix wrote: > Sparse reports this issue > core.c: note: in included file: > core.h:239:12: warning: symbol 'pmc_lpm_modes' was not declared. Should it be > static? > > Global variables should not be defined in headers. This only works > because core.h is only included by core.c. Single file use > variables should be static, so change its storage-class specifier > to static. > > Signed-off-by: Tom Rix <trix@...hat.com> Reviewed-by: David E. Box <david.e.box@...ux.intel.com> Thanks > --- > drivers/platform/x86/intel/pmc/core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/core.h > b/drivers/platform/x86/intel/pmc/core.h > index a46d3b53bf61..7a059e02c265 100644 > --- a/drivers/platform/x86/intel/pmc/core.h > +++ b/drivers/platform/x86/intel/pmc/core.h > @@ -236,7 +236,7 @@ enum ppfear_regs { > #define ADL_LPM_STATUS_LATCH_EN_OFFSET 0x1704 > #define ADL_LPM_LIVE_STATUS_OFFSET 0x1764 > > -const char *pmc_lpm_modes[] = { > +static const char *pmc_lpm_modes[] = { > "S0i2.0", > "S0i2.1", > "S0i2.2",
Powered by blists - more mailing lists