linux-kernel - Re: [PATCH] crypto: qat - Fix unsigned function returning negative constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 15:34:53 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, qat-linux@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: qat - Fix unsigned function returning negative
 constant

On Sun, Apr 24, 2022 at 04:50:31PM +0800, Haowen Bai wrote:
> The function qat_uclo_check_image_compat has an unsigned return type, but
Nit, function names should have parenthesis: qat_uclo_check_image_compat()
> returns a negative constant to indicate an error condition. So we change
> unsigned to int.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
Fixes: b4b7e67c917f ("crypto: qat - Intel(R) QAT ucode part of fw loader")
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

> ---
>  drivers/crypto/qat/qat_common/qat_uclo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_common/qat_uclo.c b/drivers/crypto/qat/qat_common/qat_uclo.c
> index 6356402a2c9e..4b6f37d6e85b 100644
> --- a/drivers/crypto/qat/qat_common/qat_uclo.c
> +++ b/drivers/crypto/qat/qat_common/qat_uclo.c
> @@ -519,7 +519,7 @@ qat_uclo_map_chunk(char *buf, struct icp_qat_uof_filehdr *file_hdr,
>  	return NULL;
>  }
>  
> -static unsigned int
> +static int
>  qat_uclo_check_image_compat(struct icp_qat_uof_encap_obj *encap_uof_obj,
>  			    struct icp_qat_uof_image *image)
>  {
> -- 
> 2.7.4
>