[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20220425144015.132707-1-ian@linux.cowan.aero>
Date: Mon, 25 Apr 2022 10:40:15 -0400
From: Ian Cowan <ian@...ux.cowan.aero>
To: Corentin Labbe <clabbe@...libre.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
mjpeg-users@...ts.sourceforge.net, linux-media@...r.kernel.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
Ian Cowan <ian@...ux.cowan.aero>,
Dan Carpenter <dan.carpenter@...cle.com>
Subject: [PATCH v2 1/4] staging: media: zoran: add logging macros
This adds the zrdev_dbg() (pointing to pci_dbg()), zrdev_err() (pointing
to pci_err()), and zrdev_info() (pointing to pci_info()) macros to the
zoran drivers. These are the preferred method for debugging and this
will allow to extract the device from the zoran struct to make the call.
Signed-off-by: Ian Cowan <ian@...ux.cowan.aero>
---
drivers/staging/media/zoran/zoran.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran.h b/drivers/staging/media/zoran/zoran.h
index 654c95fa5aba..4f7f71d8e93c 100644
--- a/drivers/staging/media/zoran/zoran.h
+++ b/drivers/staging/media/zoran/zoran.h
@@ -19,6 +19,7 @@
#define _BUZ_H_
#include <linux/debugfs.h>
+#include <linux/pci.h>
#include <media/v4l2-device.h>
#include <media/v4l2-ctrls.h>
#include <media/videobuf2-core.h>
@@ -301,6 +302,18 @@ static inline struct zoran *to_zoran(struct v4l2_device *v4l2_dev)
#endif
+/**
+ * Debugging macros
+ */
+#define zrdev_dbg(zr, format, args...) \
+ pci_dbg(zr->pci_dev, format, ##args) \
+
+#define zrdev_err(zr, format, args...) \
+ pci_err(zr->pci_dev, format, ##args) \
+
+#define zrdev_info(zr, format, args...) \
+ pci_info(zr->pci_dev, format, ##args) \
+
int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq, int dir);
void zoran_queue_exit(struct zoran *zr);
int zr_set_buf(struct zoran *zr);
--
2.35.1
Powered by blists - more mailing lists