linux-kernel - Re: [PATCH v4 1/2] of: overlay: rename variables to be consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmbElDC2GBUNY1E+@robh.at.kernel.org>
Date:   Mon, 25 Apr 2022 10:56:04 -0500
From:   Rob Herring <robh@...nel.org>
To:     frowand.list@...il.com
Cc:     linux-kernel@...r.kernel.org, Jan Kiszka <jan.kiszka@...mens.com>,
        Slawomir Stepien <slawomir.stepien@...ia.com>,
        devicetree@...r.kernel.org, Slawomir Stepien <sst@...zta.fm>,
        Rob Herring <robh+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        pantelis.antoniou@...sulko.com
Subject: Re: [PATCH v4 1/2] of: overlay: rename variables to be consistent

On Wed, 20 Apr 2022 17:25:04 -0500, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> Variables change name across function calls when there is not a good
> reason to do so.  Fix by changing "fdt" to "new_fdt" and "tree" to
> "overlay_root".
> 
> The name disparity was confusing when creating the following commit.
> The name changes are in this separate commit to make review of the
> following commmit less complex.
> 
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> 
> ---
> Changes since v3:
>    - none
> 
> Changes since v2:
>    - use new variable name "overlay_root" instead of new variable
>      new "overlay_tree"
> 
>  drivers/of/overlay.c | 94 ++++++++++++++++++++++----------------------
>  1 file changed, 47 insertions(+), 47 deletions(-)
> 

Applied, thanks!