linux-kernel - Re: [PATCH v5 2/7] sched/fair: Decay task PELT values during wakeup migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202204260942.XMp7WXYD-lkp@intel.com>
Date:   Tue, 26 Apr 2022 10:13:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vincent Donnefort <vincent.donnefort@....com>,
        peterz@...radead.org, mingo@...hat.com, vincent.guittot@...aro.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        dietmar.eggemann@....com, morten.rasmussen@....com,
        chris.redpath@....com, qperret@...gle.com,
        Vincent Donnefort <vincent.donnefort@....com>
Subject: Re: [PATCH v5 2/7] sched/fair: Decay task PELT values during wakeup
 migration

Hi Vincent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on rafael-pm/linux-next rafael-pm/thermal v5.18-rc4 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Donnefort/feec-energy-margin-removal/20220425-231901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a658353167bf2ea6052cee071dbcc13e0f229dc9
config: arc-randconfig-r043-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260942.XMp7WXYD-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/fb13cca8f6e7998f6e526a9b35f33c85d7570ab2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincent-Donnefort/feec-energy-margin-removal/20220425-231901
        git checkout fb13cca8f6e7998f6e526a9b35f33c85d7570ab2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'dequeue_entity':
>> kernel/sched/fair.c:4476:17: error: implicit declaration of function 'update_idle_cfs_rq_clock_pelt'; did you mean 'update_idle_rq_clock_pelt'? [-Werror=implicit-function-declaration]
    4476 |                 update_idle_cfs_rq_clock_pelt(cfs_rq);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                 update_idle_rq_clock_pelt
   cc1: some warnings being treated as errors


vim +4476 kernel/sched/fair.c

  4423	
  4424	static void
  4425	dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
  4426	{
  4427		/*
  4428		 * Update run-time statistics of the 'current'.
  4429		 */
  4430		update_curr(cfs_rq);
  4431	
  4432		/*
  4433		 * When dequeuing a sched_entity, we must:
  4434		 *   - Update loads to have both entity and cfs_rq synced with now.
  4435		 *   - Subtract its load from the cfs_rq->runnable_avg.
  4436		 *   - Subtract its previous weight from cfs_rq->load.weight.
  4437		 *   - For group entity, update its weight to reflect the new share
  4438		 *     of its group cfs_rq.
  4439		 */
  4440		update_load_avg(cfs_rq, se, UPDATE_TG);
  4441		se_update_runnable(se);
  4442	
  4443		update_stats_dequeue_fair(cfs_rq, se, flags);
  4444	
  4445		clear_buddies(cfs_rq, se);
  4446	
  4447		if (se != cfs_rq->curr)
  4448			__dequeue_entity(cfs_rq, se);
  4449		se->on_rq = 0;
  4450		account_entity_dequeue(cfs_rq, se);
  4451	
  4452		/*
  4453		 * Normalize after update_curr(); which will also have moved
  4454		 * min_vruntime if @se is the one holding it back. But before doing
  4455		 * update_min_vruntime() again, which will discount @se's position and
  4456		 * can move min_vruntime forward still more.
  4457		 */
  4458		if (!(flags & DEQUEUE_SLEEP))
  4459			se->vruntime -= cfs_rq->min_vruntime;
  4460	
  4461		/* return excess runtime on last dequeue */
  4462		return_cfs_rq_runtime(cfs_rq);
  4463	
  4464		update_cfs_group(se);
  4465	
  4466		/*
  4467		 * Now advance min_vruntime if @se was the entity holding it back,
  4468		 * except when: DEQUEUE_SAVE && !DEQUEUE_MOVE, in this case we'll be
  4469		 * put back on, and if we advance min_vruntime, we'll be placed back
  4470		 * further than we started -- ie. we'll be penalized.
  4471		 */
  4472		if ((flags & (DEQUEUE_SAVE | DEQUEUE_MOVE)) != DEQUEUE_SAVE)
  4473			update_min_vruntime(cfs_rq);
  4474	
  4475		if (cfs_rq->nr_running == 0)
> 4476			update_idle_cfs_rq_clock_pelt(cfs_rq);
  4477	}
  4478	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp