| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202204261646.QFXBjK7V-lkp@intel.com>
Date: Tue, 26 Apr 2022 17:01:25 +0800
From: kernel test robot <lkp@...el.com>
To: Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Mark Brown <broonie@...nel.org>,
Cezary Rojewski <cezary.rojewski@...el.com>
Subject: [broonie-sound:for-5.19 88/98] sound/soc/soc-acpi.c:34:1: error:
redefinition of 'snd_soc_acpi_find_machine'
Hi Amadeusz,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.19
head: 83f48ad508b0539f4a1737a1a125d1b66191dbc3
commit: 47a1886a610aca6a55c18ee677f9176e73162e97 [88/98] ASoC: Intel: avs: Enable AVS driver only on x86 platforms
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220426/202204261646.QFXBjK7V-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=47a1886a610aca6a55c18ee677f9176e73162e97
git remote add broonie-sound https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
git fetch --no-tags broonie-sound for-5.19
git checkout 47a1886a610aca6a55c18ee677f9176e73162e97
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> sound/soc/soc-acpi.c:34:1: error: redefinition of 'snd_soc_acpi_find_machine'
34 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:38:1: note: previous definition of 'snd_soc_acpi_find_machine' with type 'struct snd_soc_acpi_mach *(struct snd_soc_acpi_mach *)'
38 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-acpi.c: In function 'snd_soc_acpi_find_package':
>> sound/soc/soc-acpi.c:58:36: error: implicit declaration of function 'acpi_fetch_acpi_dev'; did you mean 'device_match_acpi_dev'? [-Werror=implicit-function-declaration]
58 | struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
| ^~~~~~~~~~~~~~~~~~~
| device_match_acpi_dev
sound/soc/soc-acpi.c:58:36: warning: initialization of 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> sound/soc/soc-acpi.c:64:25: error: invalid use of undefined type 'struct acpi_device'
64 | if (adev && adev->status.present && adev->status.functional) {
| ^~
sound/soc/soc-acpi.c:64:49: error: invalid use of undefined type 'struct acpi_device'
64 | if (adev && adev->status.present && adev->status.functional) {
| ^~
>> sound/soc/soc-acpi.c:80:26: error: implicit declaration of function 'acpi_extract_package' [-Werror=implicit-function-declaration]
80 | status = acpi_extract_package(myobj,
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-acpi.c: At top level:
>> sound/soc/soc-acpi.c:95:6: error: redefinition of 'snd_soc_acpi_find_package_from_hid'
95 | bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:44:1: note: previous definition of 'snd_soc_acpi_find_package_from_hid' with type 'bool(const u8 *, struct snd_soc_acpi_package_context *)' {aka '_Bool(const unsigned char *, struct snd_soc_acpi_package_context *)'}
44 | snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/soc-acpi.c:109:27: error: redefinition of 'snd_soc_acpi_codec_list'
109 | struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:51:41: note: previous definition of 'snd_soc_acpi_codec_list' with type 'struct snd_soc_acpi_mach *(void *)'
51 | static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
sound/soc/intel/avs/path.c: In function 'avs_copier_create':
>> sound/soc/intel/avs/path.c:186:31: error: invalid use of undefined type 'struct nhlt_specific_cfg'
186 | data = ep_blob->caps;
| ^~
sound/soc/intel/avs/path.c:187:36: error: invalid use of undefined type 'struct nhlt_specific_cfg'
187 | data_size = ep_blob->size;
| ^~
sound/soc/intel/avs/path.c:210:31: error: invalid use of undefined type 'struct nhlt_specific_cfg'
210 | data = ep_blob->caps;
| ^~
sound/soc/intel/avs/path.c:211:36: error: invalid use of undefined type 'struct nhlt_specific_cfg'
211 | data_size = ep_blob->size;
| ^~
vim +/snd_soc_acpi_find_machine +34 sound/soc/soc-acpi.c
cafa39b650ec3b sound/soc/soc-acpi.c Brent Lu 2021-10-30 32
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 33 struct snd_soc_acpi_mach *
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 @34 snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
95f098014815b3 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05 35 {
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 36 struct snd_soc_acpi_mach *mach;
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 37 struct snd_soc_acpi_mach *mach_alt;
95f098014815b3 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05 38
cafa39b650ec3b sound/soc/soc-acpi.c Brent Lu 2021-10-30 39 for (mach = machines; mach->id[0] || mach->comp_ids; mach++) {
cafa39b650ec3b sound/soc/soc-acpi.c Brent Lu 2021-10-30 40 if (snd_soc_acpi_id_present(mach)) {
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 41 if (mach->machine_quirk) {
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 42 mach_alt = mach->machine_quirk(mach);
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 43 if (!mach_alt)
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 44 continue; /* not full match, ignore */
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 45 mach = mach_alt;
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 46 }
a3e620f8422832 sound/soc/soc-acpi.c Keyon Jie 2018-11-16 47
7827d66946ad3a sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 48 return mach;
7827d66946ad3a sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 49 }
7827d66946ad3a sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 50 }
95f098014815b3 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05 51 return NULL;
95f098014815b3 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05 52 }
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 53 EXPORT_SYMBOL_GPL(snd_soc_acpi_find_machine);
8ceffd229f0ef1 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2016-02-08 54
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 55 static acpi_status snd_soc_acpi_find_package(acpi_handle handle, u32 level,
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 56 void *context, void **ret)
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 57 {
ff4865b3c8cd74 sound/soc/soc-acpi.c Rafael J. Wysocki 2022-01-26 @58 struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
59ce3233a538fc sound/soc/soc-acpi.c Pierre-Louis Bossart 2021-04-16 59 acpi_status status;
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 60 struct snd_soc_acpi_package_context *pkg_ctx = context;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 61
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 62 pkg_ctx->data_valid = false;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 63
ff4865b3c8cd74 sound/soc/soc-acpi.c Rafael J. Wysocki 2022-01-26 @64 if (adev && adev->status.present && adev->status.functional) {
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 65 struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 66 union acpi_object *myobj = NULL;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 67
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 68 status = acpi_evaluate_object_typed(handle, pkg_ctx->name,
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 69 NULL, &buffer,
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 70 ACPI_TYPE_PACKAGE);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 71 if (ACPI_FAILURE(status))
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 72 return AE_OK;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 73
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 74 myobj = buffer.pointer;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 75 if (!myobj || myobj->package.count != pkg_ctx->length) {
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 76 kfree(buffer.pointer);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 77 return AE_OK;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 78 }
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 79
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 @80 status = acpi_extract_package(myobj,
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 81 pkg_ctx->format, pkg_ctx->state);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 82 if (ACPI_FAILURE(status)) {
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 83 kfree(buffer.pointer);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 84 return AE_OK;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 85 }
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 86
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 87 kfree(buffer.pointer);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 88 pkg_ctx->data_valid = true;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 89 return AE_CTRL_TERMINATE;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 90 }
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 91
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 92 return AE_OK;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 93 }
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 94
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 @95 bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 96 struct snd_soc_acpi_package_context *ctx)
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 97 {
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 98 acpi_status status;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 99
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 100 status = acpi_get_devices(hid, snd_soc_acpi_find_package, ctx, NULL);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 101
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 102 if (ACPI_FAILURE(status) || !ctx->data_valid)
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 103 return false;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 104
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 105 return true;
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 106 }
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 107 EXPORT_SYMBOL_GPL(snd_soc_acpi_find_package_from_hid);
3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 108
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 @109 struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 110 {
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 111 struct snd_soc_acpi_mach *mach = arg;
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 112 struct snd_soc_acpi_codecs *codec_list =
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 113 (struct snd_soc_acpi_codecs *) mach->quirk_data;
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 114 int i;
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 115
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 116 if (mach->quirk_data == NULL)
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 117 return mach;
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 118
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 119 for (i = 0; i < codec_list->num_codecs; i++) {
0d5ea120abc020 sound/soc/soc-acpi.c Jeremy Cline 2018-01-05 120 if (!acpi_dev_present(codec_list->codecs[i], NULL, -1))
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 121 return NULL;
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 122 }
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 123
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 124 return mach;
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 125 }
7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 126 EXPORT_SYMBOL_GPL(snd_soc_acpi_codec_list);
54746dabf770eb sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15 127
:::::: The code at line 34 was first introduced by commit
:::::: 7feb2f786a46d34cac760d5e246dfbdafafa0e96 ASoC: move ACPI common code out of Intel/sst tree
:::::: TO: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
:::::: CC: Mark Brown <broonie@...nel.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists