linux-kernel - Re: [PATCH v2 RESENT] mmc-utils: Add General command CMD56 read support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpKsRyYosF4p+eEzPRi709-NZG9R5YJ=nDt5mTTnqWd6w@mail.gmail.com>
Date:   Tue, 26 Apr 2022 13:49:47 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Bean Huo <huobean@...il.com>
Cc:     adrian.hunter@...el.com, jakob.rossler@...ia.com,
        Avri.Altman@....com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH v2 RESENT] mmc-utils: Add General command CMD56 read support

On Fri, 22 Apr 2022 at 21:41, Bean Huo <huobean@...il.com> wrote:
>
> On Sun, 2022-04-17 at 13:16 +0200, Bean Huo wrote:
> > From: Bean Huo <beanhuo@...ron.com>
> >
> > We can use GEN_CMD (CMD56) to read a  data block with vendor-specific
> > format and meaning, which is very helpful and useful for customers to
> > analyze device health. This patch is to add support for this command.
> >
> > At the same time, in order to make CMD56 universal, let more users of
> > mmc-utils can benefit from this. We will allow the user to enter
> > [arg]
> > for special commands. Because some eMMC vendors provide an additional
> > set of commands beyond the GEN_CMD (CMD56) definition in the JEDEC
> > specification. These additional commands are implemented using
> > generic
> > CMD56 commands, and they return a wealth of useful information about
> > the
> > state of the NAND device. For these special purposes, the [31:1]stuff
> > bits in the CMD56 argument are used. You can refer to  Micron eMMC
> > "TN-FC-32: e·MMC Device Health Report" as an example.
> >
> > I didn't add data parsing, just print the raw data as it is vendor-
> > specific.
> >
> > Signed-off-by: Bean Huo <beanhuo@...ron.com>
> > Acked-by: Avri Altman <Avri.Altman@....com>
> > Tested-by: Rossler Jakob (Nokia - DE/Ulm) <jakob.rossler@...ia.com>
> > ---
>
> Hi Ullf,
>
> Would you be willing to merge this patch into your mmc-utils git repo?

Certainly! My apologies for the delay!

Applied to mmc-utils.git master, thanks!

Kind regards
Uffe