[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq11qxkt2t2.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 26 Apr 2022 09:03:17 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: cgel.zte@...il.com
Cc: kashyap.desai@...adcom.com, sumit.saxena@...adcom.com,
shivasharan.srikanteshwara@...adcom.com, jejb@...ux.ibm.com,
martin.petersen@...cle.com, megaraidlinux.pdl@...adcom.com,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] megaraid: fix error check return value of
register_chrdev()
> If major equal 0, register_chrdev() returns error code when it fails.
> This function dynamically allocate a major and return its number on
> success, so we should use "< 0" to check it instead of "!".
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists