[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <PH0PR84MB171845F606BC40AD653BEC8888FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM>
Date: Tue, 26 Apr 2022 13:21:37 +0000
From: "Hawkins, Nick" <nick.hawkins@....com>
To: Rob Herring <robh@...nel.org>
CC: "Verdun, Jean-Marie" <verdun@....com>,
"joel@....id.au" <joel@....id.au>, "arnd@...db.de" <arnd@...db.de>,
"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog
timer binding
-----Original Message-----
From: Rob Herring [mailto:robh@...nel.org]
Sent: Monday, April 25, 2022 5:05 PM
To: Hawkins, Nick <nick.hawkins@....com>
Cc: Verdun, Jean-Marie <verdun@....com>; joel@....id.au; arnd@...db.de; openbmc@...ts.ozlabs.org; Wim Van Sebroeck <wim@...ux-watchdog.org>; Guenter Roeck <linux@...ck-us.net>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>; linux-watchdog@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
(...)
> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions.
It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node.
Thank you for the feedback.
-Nick Hawkins
Powered by blists - more mailing lists