lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Ymf+Brpl77kvN1I4@kroah.com>
Date:   Tue, 26 Apr 2022 16:13:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mukesh Ojha <quic_mojha@...cinc.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de, sboyd@...nel.org,
        rafael@...nel.org, johannes@...solutions.net, keescook@...omium.org
Subject: Re: [PATCH v3] devcoredump : Serialize devcd_del work

On Tue, Apr 26, 2022 at 07:25:43PM +0530, Mukesh Ojha wrote:
> +	bool flg;

This is not the 1980's where we had a limited size for variable names
due to memory and compiler restrictions.

Please use vowels and descriptive names that identify what the variable
is for instantly.  "flg" is unknown.

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ