linux-kernel - Re: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ymg79qM3Wq2rlYvj@kroah.com>
Date:   Tue, 26 Apr 2022 20:37:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tom Rix <trix@...hat.com>
Cc:     jirislaby@...nel.org, nathan@...nel.org, ndesaulniers@...gle.com,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported

On Tue, Apr 26, 2022 at 11:16:35AM -0700, Tom Rix wrote:
> 
> On 4/26/22 5:12 AM, Greg KH wrote:
> > On Tue, Apr 26, 2022 at 08:05:54AM -0400, Tom Rix wrote:
> > > The clang build fails with
> > > n_gsm.c:940:13: error: variable 'size' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> > >          } else if (dlci->adaption == 2) {
> > >                     ^~~~~~~~~~~~~~~~~~~
> > > 
> > > The else should return an error, so return -EINVAL.
> > > 
> > > Signed-off-by: Tom Rix <trix@...hat.com>
> > What commit id does this fix?  Any reason you didn't cc: the author of
> > the recent changes to this code?
> Sorry missed this part.

Please always do that, otherwise it's hard to track, right?

> > Is this the same issue that 0-day reported?
> 
> Maybe, it was part of next's update today.  Where is 0-day reported ?

On the same mailing list you posted this patch to:
	https://lore.kernel.org/r/202204230704.5MxboEEo-lkp@intel.com

thanks,

greg k-h