linux-kernel - Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings by 34% tree-wide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2ZUfpWiHh6yeAy3fFP8k5BcE8crkis7Savxhdym1e-FQ@mail.gmail.com>
Date:   Tue, 26 Apr 2022 20:56:02 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc:     Yury Norov <yury.norov@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings
 by 34% tree-wide

On Tue, Apr 26, 2022 at 6:16 PM Vincent Mailhol
<mailhol.vincent@...adoo.fr> wrote:

> +__diag_push();
> +__diag_ignore(GCC, 8, "-Wtype-limits",
> +             "GENMASK(size - 1, 0) yields 'comparison of unsigned expression in < 0 is always false' which is OK");
> +

Are you sure gcc-8 is the correct version to check for? If older
versions had this
already, you may have to add the magic bits in the compiler-gcc.h header.

Otherwise, this looks sensible to me.

      Arnd