linux-kernel - Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Apr 2022 07:00:48 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <allen-kh.cheng@...iatek.com>
CC:     <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        <devicetree@...r.kernel.org>, <hsinyi@...omium.org>,
        <krzysztof.kozlowski@...onical.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>,
        <robh+dt@...nel.org>, <ryder.lee@...nel.org>, <wenst@...omium.org>
Subject: Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile

Hi Allen, 

> Add basic chip support for Mediatek MT8186.

s/Mediatek/MediaTek/

> 
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@...iatek.com>

...snip...

> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause

> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + */
> +/dts-v1/;
> +#include "mt8186.dtsi"
> +
> +/ {


..snip...

> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> new file mode 100644
> index 000000000000..e8d8867412e3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> @@ -0,0 +1,932 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause

> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + * Author: Allen-KH Cheng <allenn-kh.cheng@...iatek.com>
> + */
> +/dts-v1/;
>


thanks,
Miles