linux-kernel - Re: [PATCH] x86/speculation: Add missing prototype for unpriv_ebpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKjfQMG_zFf9F9P7m0UzqESs7XoRy=udqrDSodxa8yBpg@mail.gmail.com>
Date:   Tue, 26 Apr 2022 16:36:08 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Borislav Petkov <bp@...en8.de>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     Josh Poimboeuf <jpoimboe@...hat.com>, bpf <bpf@...r.kernel.org>,
        X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] x86/speculation: Add missing prototype for unpriv_ebpf_notify()

On Tue, Apr 26, 2022 at 6:36 AM Borislav Petkov <bp@...en8.de> wrote:
>
> + bpf@...r.kernel.org
>
> Let's sync with bpf folks on who takes this. I could route it through tip ...

I don't remember seeing the original patch on the bpf list.
I'm guessing it was done in private as part of bhb series?
Feel free to land it via tip.
Hopefully there will be no conflicts.

> On Mon, Apr 25, 2022 at 04:40:02PM -0700, Josh Poimboeuf wrote:
> > Fix the following warnings seen with "make W=1":
> >
> >   kernel/sysctl.c:183:13: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> >     183 | void __weak unpriv_ebpf_notify(int new_state)
> >         |             ^~~~~~~~~~~~~~~~~~
> >
> >   arch/x86/kernel/cpu/bugs.c:659:6: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> >     659 | void unpriv_ebpf_notify(int new_state)
> >         |      ^~~~~~~~~~~~~~~~~~
> >
> > Fixes: 44a3918c8245 ("x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > ---
> >  include/linux/bpf.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> > index bdb5298735ce..ecc3d3ec41cf 100644
> > --- a/include/linux/bpf.h
> > +++ b/include/linux/bpf.h
> > @@ -2085,6 +2085,8 @@ void bpf_offload_dev_netdev_unregister(struct bpf_offload_dev *offdev,
> >                                      struct net_device *netdev);
> >  bool bpf_offload_dev_match(struct bpf_prog *prog, struct net_device *netdev);
> >
> > +void unpriv_ebpf_notify(int new_state);
> > +
> >  #if defined(CONFIG_NET) && defined(CONFIG_BPF_SYSCALL)
> >  int bpf_prog_offload_init(struct bpf_prog *prog, union bpf_attr *attr);
> >
> > --
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette