linux-kernel - Re: [PATCH] null-blk: save memory footprint for struct nullb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3662c725-a919-443a-9ab8-dc536cb5c03b@nvidia.com>
Date:   Tue, 26 Apr 2022 06:20:19 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Yu Kuai <yukuai3@...wei.com>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "shinichiro.kawasaki@....com" <shinichiro.kawasaki@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "yi.zhang@...wei.com" <yi.zhang@...wei.com>,
        "chaitanya.kulkarni@....com" <chaitanya.kulkarni@....com>
Subject: Re: [PATCH] null-blk: save memory footprint for struct nullb_cmd

On 4/25/22 19:21, Yu Kuai wrote:
> Total 16 bytes can be saved in two ways:
> 
> 1) The field 'bio' will only be used in bio based mode, and the field
>     'rq' will only be used in mq mode. Since they won't be used in the
>     same time, declare a union for them.
> 2) The field 'bool fake_timeout' can be placed in the hole after the
>     field 'error'.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck