linux-kernel - Re: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <275d7e40-a4bf-624a-6072-9750c6cb1ff0@roeck-us.net>
Date:   Tue, 26 Apr 2022 01:35:18 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "liuxp11@...natelecom.cn" <liuxp11@...natelecom.cn>,
        wim <wim@...ux-watchdog.org>, Tzung-Bi Shih <tzungbi@...nel.org>
Cc:     linux-watchdog <linux-watchdog@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with
 macro definition

On 4/26/22 01:27, liuxp11@...natelecom.cn wrote:
>     On 4/26/22 00:10, Liu Xinpeng wrote:
>      > Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.
>      >
>      > Signed-off-by: Liu Xinpeng <liuxp11@...natelecom.cn>
>      > Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>
>     Also, Tzung-Bi never sent a Reviewed-by: tag. As with the other patches,
>     this is completely inappropriate. Really, who gave you that idea ?
>     You adding such tags without receiving them means we can never trust
>     your patches again since you are making things up.
>     Guenter
>     -->Very sorry about this. I am not clearly when need to add "Reviewed-by: tag",
>     Just expressing thanks.
> 

If you get a Reviewed-by: tag for a patch, you keep it in the next version of
that patch unless there are substantial changes. You _never_ add one yourself.

Guenter