linux-kernel - Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2B3258A9-47BA-4AA3-A4E8-BE255D5F4506@linux.microsoft.com>
Date:   Wed, 27 Apr 2022 08:53:26 -0700
From:   Allen Pais <apais@...ux.microsoft.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     olivier.dautricourt@...lia.com, sr@...x.de,
        Kees Cook <keescook@...omium.org>,
        linux-hardening@...r.kernel.org, ludovic.desroches@...rochip.com,
        tudor.ambarus@...rochip.com, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, nsaenz@...nel.org,
        paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
        gustavo.pimentel@...opsys.com, vireshk@...nel.org,
        andriy.shevchenko@...ux.intel.com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, afaerber@...e.de, mani@...nel.org,
        logang@...tatee.com, sanju.mehta@....com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org,
        krzysztof.kozlowski@...aro.org, green.wan@...ive.com,
        orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org,
        wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue


>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
> 
> What is the reason for tasklet removal, I am not sure old is a reason to
> remove an API...

 While we moved to modernised version of tasklet API, there was
A request to entirely remove tasklets. The following patch is an attempt
Towards it. 

> 
>> 
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
> 
> Dmaengines need very high throughput, one of the reasons in dmaengine
> API design to use tasklet was higher priority given to them. Will the
> workqueue allow that...?

  It is interesting that you brought up this point. I haven’t had the opportunity
To test the changes by stressing the kernel, what tests/benchmarks would
You prefer to see run on with these changes.

Thanks.

> 
> -- 
> ~Vinod