linux-kernel - Re: [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220427085502.719366ad@kernel.org>
Date:   Wed, 27 Apr 2022 08:55:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Min Li <min.li.xe@...esas.com>
Cc:     "richardcochran@...il.com" <richardcochran@...il.com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS
 support

On Wed, 27 Apr 2022 14:32:03 +0000 Min Li wrote:
> > On Tue, 26 Apr 2022 15:32:53 -0400 Min Li wrote:  
> > > Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY for  
> > gettime  
> > > and settime exclusively  
> > 
> > Does not build on 32 bit.
> >   
> 
> Hi Jakub
> 
> I compiled with arm-linux-gnueabi-
> 
> By 32 bit, did you mean x86?

Yup! I think arm does not have the 64b division problems x86 has.
We hit the dreaded 

ERROR: modpost: "__divdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!
ERROR: modpost: "__udivdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!

on 32b x86 builds. Sorry for lack of clarity.