linux-kernel - Re: [PATCH] kernfs: fix NULL dereferencing in kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yml9Djpe5HT0HqoN@slm.duckdns.org>
Date:   Wed, 27 Apr 2022 07:27:42 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jirka Hladky <jhladky@...hat.com>,
        Thorsten Leemhuis <regressions@...mhuis.info>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        regressions@...ts.linux.dev,
        Justin Forbes <jforbes@...oraproject.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH] kernfs: fix NULL dereferencing in kernfs_remove

On Wed, Apr 27, 2022 at 10:21:51AM -0700, Minchan Kim wrote:
> kernfs_remove supported NULL kernfs_node param to bail out but revent
                                                                 ^
                                                                 typo
> per-fs lock change introduced regression that dereferencing the
> param without NULL check so kernel goes crash.
> 
> This patch checks the NULL kernfs_node in kernfs_remove and if so,
> just return.
...
> Cc: stable@...r.kernel.org
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215696
> Link: https://lore.kernel.org/lkml/CAE4VaGDZr_4wzRn2___eDYRtmdPaGGJdzu_LCSkJYuY9BEO3cw@mail.gmail.com/
> Fixes: 393c3714081a (kernfs: switch global kernfs_rwsem lock to per-fs lock)
> Reported-by: Jirka Hladky <jhladky@...hat.com>
> Tested-by: Jirka Hladky <jhladky@...hat.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun