linux-kernel - Re: [PATCH v4 42/45] media: sun6i-csi: Request a shared interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2179026.iZASKD2KPV@jernej-laptop>
Date:   Wed, 27 Apr 2022 21:02:30 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Yong Deng <yong.deng@...ewell.com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Samuel Holland <samuel@...lland.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 42/45] media: sun6i-csi: Request a shared interrupt

Dne petek, 15. april 2022 ob 17:28:08 CEST je Paul Kocialkowski napisal(a):
> Request our interrupt shared since it is typically shared with the isp
> block. The interrupt routine looks good to go for shared irq.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
> 3963a88a2e0b..a88deb8ba1e7 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -264,8 +264,8 @@ static int sun6i_csi_resources_setup(struct
> sun6i_csi_device *csi_dev, goto error_clock_rate_exclusive;
>  	}
> 
> -	ret = devm_request_irq(dev, irq, sun6i_csi_interrupt, 0, 
SUN6I_CSI_NAME,
> -			       csi_dev);
> +	ret = devm_request_irq(dev, irq, sun6i_csi_interrupt, IRQF_SHARED,
> +			       SUN6I_CSI_NAME, csi_dev);
>  	if (ret) {
>  		dev_err(dev, "failed to request interrupt\n");
>  		goto error_clock_rate_exclusive;