linux-kernel - Re: [PATCH v4 37/45] media: sun6i-csi: Rename the capture video device to sun6i-csi-capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14612220.tv2OnDr8pf@jernej-laptop>
Date:   Wed, 27 Apr 2022 21:50:54 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Yong Deng <yong.deng@...ewell.com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Samuel Holland <samuel@...lland.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 37/45] media: sun6i-csi: Rename the capture video device to sun6i-csi-capture

Dne petek, 15. april 2022 ob 17:28:03 CEST je Paul Kocialkowski napisal(a):
> Now that the driver is properly split between bridge and capture,
> rename the video device to highlight its role and be in line with
> the bridge entity naming.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 3 ++-
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c index
> a6619d083308..c3b1e1411da4 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c
> @@ -1027,7 +1027,8 @@ int sun6i_csi_capture_setup(struct sun6i_csi_device
> *csi_dev)
> 
>  	/* Video Device */
> 
> -	strscpy(video_dev->name, SUN6I_CSI_NAME, sizeof(video_dev->name));
> +	strscpy(video_dev->name, SUN6I_CSI_CAPTURE_NAME,
> +		sizeof(video_dev->name));
>  	video_dev->device_caps = V4L2_CAP_VIDEO_CAPTURE | 
V4L2_CAP_STREAMING;
>  	video_dev->vfl_dir = VFL_DIR_RX;
>  	video_dev->release = video_device_release_empty;
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h index
> a61db3bc72e5..59c57bcefeec 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h
> @@ -11,6 +11,8 @@
>  #include <media/v4l2-dev.h>
>  #include <media/videobuf2-core.h>
> 
> +#define SUN6I_CSI_CAPTURE_NAME	"sun6i-csi-capture"
> +
>  #define SUN6I_CSI_CAPTURE_WIDTH_MIN	32
>  #define SUN6I_CSI_CAPTURE_WIDTH_MAX	4800
>  #define SUN6I_CSI_CAPTURE_HEIGHT_MIN	32