linux-kernel - Re: [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Apr 2022 13:05:11 -0700
From:   Zev Weiss <zev@...ilderbeest.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Renze Nicolai <renze@...lus.nl>,
        Oleksandr Natalenko <oleksandr@...alenko.name>,
        openbmc@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775

On Wed, Apr 27, 2022 at 09:37:20AM PDT, Krzysztof Kozlowski wrote:
>On 27/04/2022 08:44, Zev Weiss wrote:
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  nuvoton,tsi-channel-mask:
>>>> +    description:
>>>> +      Bitmask indicating which TSI temperature sensor channels are
>>>> +      active.  LSB is TSI0, bit 1 is TSI1, etc.
>>>
>>> Need a type/ref.
>>>
>>
>> Ack, thanks.
>
>Did you test the bindings after the changes? Using reviewers time
>instead of testing by yourself with an automated tool is quite a waste.
>

Yeah, sorry about that -- with uint32 $ref added it passes dt_binding_check;
I'll re-send with that change.


Zev