linux-kernel - Re: [PATCH 2/2] phy: qcom-qmp: fix reset-controller leak on probe errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Apr 2022 08:01:42 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Subject: Re: [PATCH 2/2] phy: qcom-qmp: fix reset-controller leak on probe
 errors

On Mon, Apr 25, 2022 at 11:45:29AM +0200, Philipp Zabel wrote:
> Hi Johan,
> 
> On Fr, 2022-04-22 at 15:09 +0200, Johan Hovold wrote:
> > Make sure to release the lane reset controller in case of a late probe
> > error (e.g. probe deferral).
> 
> Right. grepping for "of_reset_control_get", there seem to be are a few
> other drivers that might share the same issue...

Yeah, I'm sure there are more of these.
 
> > Note that due to the reset controller being defined in devicetree in
> > (questionable) "lane" child nodes, devm_reset_control_get_exclusive()
> > cannot be used (and we shouldn't add devres helpers for the legacy reset
> > controller API).
> 
> Do you mean of_reset_control_get()? Maybe you could switch to
> of_reset_control_get_exclusive() while at it?

Right, I was referring to of_reset_control_get() but obviously
of_reset_control_get_exclusive() could still get a devres version so
that sentence in parenthesis doesn't make much sense.

I must have mistakingly imagined that the latter also retrieved the
struct device_node from a struct device like the current devres helpers
do.

> That one might warrant a devres helper if other drivers were to adopt
> the same pattern.

Right.

> The patch itself looks fine to me,
> 
> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

Thanks for reviewing. I'll send a v2 with an updated commit message and
switch to the new API in a new follow-on patch.

Johan