[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220427061042.6xmzg7i6ozhlbhzi@ti.com>
Date: Wed, 27 Apr 2022 11:40:42 +0530
From: Pratyush Yadav <p.yadav@...com>
To: Matthias Schiffer <matthias.schiffer@...tq-group.com>
CC: Mark Brown <broonie@...nel.org>,
Tudor Ambarus <tudor.ambarus@...rochip.com>,
Vignesh Raghavendra <vigneshr@...com>,
Ramuthevar Vadivel Murugan
<vadivel.muruganx.ramuthevar@...ux.intel.com>,
<linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] spi: cadence-quadspi: drop cqspi_set_protocol()
On 20/04/22 05:56PM, Matthias Schiffer wrote:
> As suggested, this removes the whole cqspi_set_protocol() function, as it
> is not actually needed:
>
> - Checks for unsupported operations are already handled by supports_op(),
> removing the need to distinguish DTR and non-DTR modes in the buswidth
> setup
> - supports_op() ensures that the DTR flags match for all relevant parts of
> an operation, so op->cmd.dtr can be used instead of copying the flag to
> the cqspi_flash_pdata
> - The logic in cqspi_set_protocol() is moved to cqspi_calc_rdreg() and
> cqspi_write_setup() (with a helper macro CQSPI_OP_WIDTH())
>
> The helper macro checks nbytes instead of buswidth for 0, for consistency
> with supports_op() etc.
>
> Suggested-by: Pratyush Yadav <p.yadav@...com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
I know the patch has already been applied, but FWIW,
Reviewed-by: Pratyush Yadav <p.yadav@...com>
Also did some basic testing on the latest linux-next, which has your
patches. Things seem to work fine.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
Powered by blists - more mailing lists