linux-kernel - Re: [EXT] Re: [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx series chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmjktXZDb5ELR8Xp@kroah.com>
Date:   Wed, 27 Apr 2022 08:37:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Manjunatha Venkatesh <manjunatha.venkatesh@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "will@...nel.org" <will@...nel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "mb@...htnvm.io" <mb@...htnvm.io>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "arnd@...db.d" <arnd@...db.d>, "mst@...hat.com" <mst@...hat.com>,
        "javier@...igon.com" <javier@...igon.com>,
        "mikelley@...rosoft.com" <mikelley@...rosoft.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "sunilmut@...rosoft.com" <sunilmut@...rosoft.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "rvmanjumce@...il.com" <rvmanjumce@...il.com>,
        Ashish Deshpande <ashish.deshpande@....com>
Subject: Re: [EXT] Re: [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx
 series chip

On Wed, Apr 27, 2022 at 06:24:14AM +0000, Manjunatha Venkatesh wrote:
> Hello Greg,
> 
> Thanks for sharing your comments with us and apologies for our delayed
> response. 
> We have done a thorough review internally and would like to put forward a
> proposal for your consideration.
> 
> 1)  In our next submission we will define the kernel/user API clearly with
> kernel pre-defined IOCTL macros in the uapi header file and follow the
> standard IOCTL rules.

Why do you need ioctls at all?  Anyway, submit the code and we can
review the api then, I have no recollection of the previous submission
as it was thousands of patches ago.

> 2)  We agree that this is a simple driver which may not need a dedicated
> directory under Linux/drivers so we will move the driver to "misc" folder.
> 3)  We can also share some applications which show the usage of these driver
> API's from the user space.

That's great, submit away!

greg k-h