linux-kernel - Re: [PATCH v2] crypto: inside-secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <165104586605.3327.5179101284332639573@kwain>
Date:   Wed, 27 Apr 2022 09:51:06 +0200
From:   Antoine Tenart <atenart@...nel.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>,
        davem@...emloft.net, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Juerg Haefliger <juergh@...tonmail.com>
Subject: Re: [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros

Quoting Juerg Haefliger (2022-04-27 09:43:51)
> The safexcel module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
> 
> Signed-off-by: Juerg Haefliger <juergh@...tonmail.com>

LGTM, thanks!

Acked-by: Antoine Tenart <atenart@...nel.org>

> ---
> v2:
>  Add legacy fallback firmware locations.
> ---
>  drivers/crypto/inside-secure/safexcel.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 9ff885d50edf..9b1a158aec29 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1997,3 +1997,12 @@ MODULE_AUTHOR("Igal Liberman <igall@...vell.com>");
>  MODULE_DESCRIPTION("Support for SafeXcel cryptographic engines: EIP97 & EIP197");
>  MODULE_LICENSE("GPL v2");
>  MODULE_IMPORT_NS(CRYPTO_INTERNAL);
> +
> +MODULE_FIRMWARE("ifpp.bin");
> +MODULE_FIRMWARE("ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
> -- 
> 2.32.0
>