linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180: wormdingler: Add wormdingler dts files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Apr 2022 18:39:05 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     "Joseph S. Barrera III" <joebar@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Douglas Anderson <dianders@...omium.org>,
        Alexandru M Stan <amstan@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7180: wormdingler: Add wormdingler
 dts files.

Quoting Joseph S. Barrera III (2022-04-26 15:12:06)
> Wormdingler is a trogdor-based board, shipping to customers as the Lenovo IdeaPad Chromebook Duet 3. These dts files are copies from the downstream Chrome OS 5.4 kernel, but with the camera (sc7180-trogdor-mipi-camera.dtsi) #include removed.
>

Please wrap lines at 75 columns or so.

> Author: Joseph S. Barrera III <joebar@...omium.org>

This shouldn't be necessary as it matches the From: line of the email.

> Signed-off-by: Joseph S. Barrera III <joebar@...omium.org>
> ---
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> new file mode 100644
> index 000000000000..945caa21962f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> @@ -0,0 +1,416 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Wormdingler board device tree source
> + *
> + * Copyright 2021 Google LLC.
> + */
> +
> +/dts-v1/;
> +
[...]
> +
> +/* PINCTRL - modifications to sc7180-trogdor.dtsi */
> +
> +/*
> + * No eDP on this board but it's logically the same signal so just give it
> + * a new name and assign the proper GPIO.
> + */
> +
> +tp_en: &en_pp3300_dx_edp {
> +       pinmux {
> +               pins = "gpio85";
> +               };

Please add a newline here and deindent the "};" to match pinconf below.

> +       pinconf {
> +               pins = "gpio85";
> +       };
> +};
> +