linux-kernel - Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings by 34% tree-wide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220427132120.3128595-1-alexandr.lobakin@intel.com>
Date:   Wed, 27 Apr 2022 15:21:20 +0200
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        Yury Norov <yury.norov@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, gcc@....gnu.org,
        Rikard Falkeborn <rikard.falkeborn@...il.com>
Subject: Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings by 34% tree-wide

From: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Date: Wed, 27 Apr 2022 11:58:58 +0900

> + Alexander Lobakin <alexandr.lobakin@...el.com>

I was okay even with the previous solution to modify
GENMASK_INPUT_CHECK() and this one is fine to me as well.
The presense of warnings on W=1 doesn't mean we shouldn't fix W=12
etc. Especially when their rootfs are in headers and blow up the
output. Especially when it's 1/3 of all warnings.
`make W=12[e] path/to/new/file` is still useful to ensure that we
don't add more warnings to the already existing ones. When there are
problematic header, it's easier to miss something and impossible to
pipe `make W=12e` in a script to do that in an automated manner.
Thanks!

Acked-by: Alexander Lobakin <alexandr.lobakin@...el.com>

> 
> On Wed. 27 Apr 2022 at 05:42, Yury Norov <yury.norov@...il.com> wrote:

[...]

> Yours sincerely,
> Vincent Mailhol

Al