lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YmlJGQavHNOVjzQF@amd.com>
Date:   Wed, 27 Apr 2022 21:46:01 +0800
From:   Huang Rui <ray.huang@....com>
To:     "Limonciello, Mario" <Mario.Limonciello@....com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "open list:AMD PSTATE DRIVER" <linux-pm@...r.kernel.org>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/6] cpufreq: amd-pstate: Only show shared memory
 solution message once

On Fri, Apr 15, 2022 at 12:47:57AM +0800, Limonciello, Mario wrote:
> A message is emitted to let users know they can enable shared memory,
> but it shows on all CPUs.
> 
> As this parameter is system-wide not CPU specific, it doesn't make
> sense to show 8+ times.  Modify it to print only once.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Reviewed-by: Huang Rui <ray.huang@....com>

> ---
> v2->v3:
>  * New patch
> 
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7be38bc6a673..ecd1fd5e5b5a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -666,7 +666,7 @@ static int __init amd_pstate_init(void)
>  		static_call_update(amd_pstate_init_perf, cppc_init_perf);
>  		static_call_update(amd_pstate_update_perf, cppc_update_perf);
>  	} else {
> -		pr_info("This processor supports shared memory solution, you can enable it with amd_pstate.shared_mem=1\n");
> +		pr_info_once("A processor on this system supports the shared memory solution, you can enable it with amd_pstate.shared_mem=1\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.34.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ