linux-kernel - Re: [PATCH] scsi: sr: Fix some cdroms automatically ejected when booting into the system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1sfpxkjpo.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 27 Apr 2022 22:51:02 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     jinxiaobo <jinxiaobo@...ontech.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: sr: Fix some cdroms automatically ejected when
 booting into the system


Hi jinxiaobo!

> sr_get_events() has been called before udev starts when SCSI CDROM is
> built-in and AHCI SATA is bulit-in,so sr events propagated to user
> space are not handled.  if both is loadable, udev will handle sr
> events, some cdroms may eject.  We need call sr_get_events() once
> before device_add_disk() to keep the same result, whether both are
> built-in or loadable.

I am not sure how calling sr_get_events() and throwing away the result
ensures that events get propagated to udev. Isn't this just changing
timing slightly?

-- 
Martin K. Petersen	Oracle Linux Engineering