linux-kernel - Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9647245d-b0b5-12d1-fef2-7a5f759f908b@collabora.com>
Date:   Thu, 28 Apr 2022 21:41:25 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Steven Price <steven.price@....com>,
        David Airlie <airlied@...ux.ie>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Gurchetan Singh <gurchetansingh@...omium.org>,
        Chia-I Wu <olvaffe@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Daniel Almeida <daniel.almeida@...labora.com>,
        Gert Wollny <gert.wollny@...labora.com>,
        Gustavo Padovan <gustavo.padovan@...labora.com>,
        Daniel Stone <daniel@...ishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Rob Herring <robh@...nel.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        Rob Clark <robdclark@...il.com>,
        Emil Velikov <emil.l.velikov@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        Qiang Yu <yuq825@...il.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Christian König <christian.koenig@....com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        Dmitry Osipenko <digetx@...il.com>
Subject: Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj
 on panfrost_mmu_map_fault_addr() error

28.04.2022 16:19, Steven Price пишет:
> On 24/04/2022 20:04, Dmitry Osipenko wrote:
>> When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be
>> unreferenced and not the shmem object that backs that mapping.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> 
> Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
> 
> Reviewed-by: Steven Price <steven.price@....com>

Thank you for the fixes tag. It appeared to me that this problem existed
since the first addition of the srinker when I was looking up the
offending commit, my bad :)