linux-kernel - Re: [PATCH v2] zram: remove double compression logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220428200107.hz65qvxf2aoz27q2@cab-wsm-0029881>
Date:   Thu, 28 Apr 2022 20:01:12 +0000
From:   Aleksey Romanov <AVRomanov@...rdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        "minchan@...nel.org" <minchan@...nel.org>
CC:     "minchan@...nel.org" <minchan@...nel.org>,
        "ngupta@...are.org" <ngupta@...are.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "axboe@...omium.org" <axboe@...omium.org>,
        kernel <kernel@...rdevices.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mnitenko@...il.com" <mnitenko@...il.com>,
        Dmitry Rokosov <DDRokosov@...rdevices.ru>
Subject: Re: [PATCH v2] zram: remove double compression logic

Thanks for the reply!

On Wed, Apr 27, 2022 at 08:30:16PM +0900, Sergey Senozhatsky wrote:
> On (22/04/27 13:03), Alexey Romanov wrote:
> > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> > index cb253d80d72b..4be6caf43b1d 100644
> > --- a/drivers/block/zram/zram_drv.c
> > +++ b/drivers/block/zram/zram_drv.c
> > @@ -1153,9 +1153,8 @@ static ssize_t debug_stat_show(struct device *dev,
> >  
> >  	down_read(&zram->init_lock);
> >  	ret = scnprintf(buf, PAGE_SIZE,
> > -			"version: %d\n%8llu %8llu\n",
> > +			"version: %d\n%8llu\n",
> >  			version,
> > -			(u64)atomic64_read(&zram->stats.writestall),
> >  			(u64)atomic64_read(&zram->stats.miss_free));
> >  	up_read(&zram->init_lock);
> 
> I think this also has to bump `version` to 2, since format of the
> file has changed.

Yes, I'll do that in the next patch.

Minchan, do you have any suggestions on this patch? 
I want to fix Sergey suggestion and sumbit next patch.