linux-kernel - [kas:lam 6/10] drivers/char/ipmi/ipmi_watchdog.c:776:37: sparse: sparse: incorrect type in initializer (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 07:14:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [kas:lam 6/10] drivers/char/ipmi/ipmi_watchdog.c:776:37: sparse:
 sparse: incorrect type in initializer (different address spaces)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git lam
head:   956305b67dd062e5a58c68c871dee2ee1d579feb
commit: 2d7493c0421d267a906653b33aca69bf87f0595f [6/10] x86/uaccess: Remove tags from the address before checking
config: x86_64-randconfig-s022 (https://download.01.org/0day-ci/archive/20220429/202204290719.Ro26lojw-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git/commit/?id=2d7493c0421d267a906653b33aca69bf87f0595f
        git remote add kas https://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git
        git fetch --no-tags kas lam
        git checkout 2d7493c0421d267a906653b33aca69bf87f0595f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ipmi_watchdog.c:776:37: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected char const [noderef] __user *__ptr_clean @@     got char const * @@
   drivers/char/ipmi/ipmi_watchdog.c:776:37: sparse:     expected char const [noderef] __user *__ptr_clean
   drivers/char/ipmi/ipmi_watchdog.c:776:37: sparse:     got char const *

vim +776 drivers/char/ipmi/ipmi_watchdog.c

55929332c92e5d3 Arnd Bergmann  2010-04-27  758  
^1da177e4c3f415 Linus Torvalds 2005-04-16  759  static ssize_t ipmi_write(struct file *file,
^1da177e4c3f415 Linus Torvalds 2005-04-16  760  			  const char  __user *buf,
^1da177e4c3f415 Linus Torvalds 2005-04-16  761  			  size_t      len,
^1da177e4c3f415 Linus Torvalds 2005-04-16  762  			  loff_t      *ppos)
^1da177e4c3f415 Linus Torvalds 2005-04-16  763  {
^1da177e4c3f415 Linus Torvalds 2005-04-16  764  	int rv;
^1da177e4c3f415 Linus Torvalds 2005-04-16  765  
^1da177e4c3f415 Linus Torvalds 2005-04-16  766  	if (len) {
^1da177e4c3f415 Linus Torvalds 2005-04-16  767  		if (!nowayout) {
^1da177e4c3f415 Linus Torvalds 2005-04-16  768  			size_t i;
^1da177e4c3f415 Linus Torvalds 2005-04-16  769  
^1da177e4c3f415 Linus Torvalds 2005-04-16  770  			/* In case it was set long ago */
^1da177e4c3f415 Linus Torvalds 2005-04-16  771  			expect_close = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16  772  
^1da177e4c3f415 Linus Torvalds 2005-04-16  773  			for (i = 0; i != len; i++) {
^1da177e4c3f415 Linus Torvalds 2005-04-16  774  				char c;
^1da177e4c3f415 Linus Torvalds 2005-04-16  775  
^1da177e4c3f415 Linus Torvalds 2005-04-16 @776  				if (get_user(c, buf + i))
^1da177e4c3f415 Linus Torvalds 2005-04-16  777  					return -EFAULT;
^1da177e4c3f415 Linus Torvalds 2005-04-16  778  				if (c == 'V')
^1da177e4c3f415 Linus Torvalds 2005-04-16  779  					expect_close = 42;
^1da177e4c3f415 Linus Torvalds 2005-04-16  780  			}
^1da177e4c3f415 Linus Torvalds 2005-04-16  781  		}
^1da177e4c3f415 Linus Torvalds 2005-04-16  782  		rv = ipmi_heartbeat();
^1da177e4c3f415 Linus Torvalds 2005-04-16  783  		if (rv)
^1da177e4c3f415 Linus Torvalds 2005-04-16  784  			return rv;
^1da177e4c3f415 Linus Torvalds 2005-04-16  785  	}
3976df9b04c113a Mark Rustad    2008-07-10  786  	return len;
^1da177e4c3f415 Linus Torvalds 2005-04-16  787  }
^1da177e4c3f415 Linus Torvalds 2005-04-16  788  

:::::: The code at line 776 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp