linux-kernel - Re: [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ymsj8wJ/T/vxsVu+@equinox>
Date:   Fri, 29 Apr 2022 00:32:03 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org
Subject: Re: [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN
 obsolete

On Wed, Apr 27, 2022 at 09:24:34AM -0400, Paul Gortmaker wrote:
> These were only implemented by the IDE CD driver, which has since
> been removed.  Given that nobody is likely to create new CD/DVD
> hardware (and associated drivers) we can mark these appropriately.
> 
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Phillip Potter <phil@...lpotter.co.uk>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  Documentation/userspace-api/ioctl/cdrom.rst | 6 ++++++
>  include/uapi/linux/cdrom.h                  | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst
> index 682948fc88a3..2ad91dbebd7c 100644
> --- a/Documentation/userspace-api/ioctl/cdrom.rst
> +++ b/Documentation/userspace-api/ioctl/cdrom.rst
> @@ -718,6 +718,9 @@ CDROMPLAYBLK
>  
>  
>  CDROMGETSPINDOWN
> +	Obsolete, was ide-cd only
> +
> +
>  	usage::
>  
>  	  char spindown;
> @@ -736,6 +739,9 @@ CDROMGETSPINDOWN
>  
>  
>  CDROMSETSPINDOWN
> +	Obsolete, was ide-cd only
> +
> +
>  	usage::
>  
>  	  char spindown
> diff --git a/include/uapi/linux/cdrom.h b/include/uapi/linux/cdrom.h
> index 804ff8d98f71..011e594e4a0d 100644
> --- a/include/uapi/linux/cdrom.h
> +++ b/include/uapi/linux/cdrom.h
> @@ -103,7 +103,7 @@
>  #define CDROMREADALL		0x5318	/* read all 2646 bytes */
>  
>  /* 
> - * These ioctls are (now) only in ide-cd.c for controlling 
> + * These ioctls were only in (now removed) ide-cd.c for controlling
>   * drive spindown time.  They should be implemented in the
>   * Uniform driver, via generic packet commands, GPCMD_MODE_SELECT_10,
>   * GPCMD_MODE_SENSE_10 and the GPMODE_POWER_PAGE...
> -- 
> 2.33.0
> 

Same for this one, looks good, will send on. Many thanks.

Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil