linux-kernel - Re: ndctl tests usable?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2684252-8c85-ba0e-2356-29837e836f6f@linux.ibm.com>
Date:   Thu, 28 Apr 2022 10:02:47 +0530
From:   Shivaprasad G Bhat <sbhat@...ux.ibm.com>
To:     Michal Suchánek <msuchanek@...e.de>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux NVDIMM <nvdimm@...ts.linux.dev>
Subject: Re: ndctl tests usable?

On 4/26/22 23:39, Michal Suchánek wrote:
> On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote:
>> On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek <msuchanek@...e.de> wrote:
>>>
>>> On Tue, Apr 26, 2022 at 09:32:24AM -0700, Dan Williams wrote:
>>>> On Tue, Apr 26, 2022 at 9:15 AM Michal Suchánek <msuchanek@...e.de> wrote:
>>>>>
>>>>> On Tue, Apr 26, 2022 at 08:51:25AM -0700, Dan Williams wrote:
>>>>>> On Tue, Apr 26, 2022 at 5:39 AM Michal Suchánek <msuchanek@...e.de> wrote:
>>>>>>>
> ...
>>>>
>>>> The modinfo just tells you what modules are available, but it does not
>>>> necessarily indicate which modules are actively loaded in the system
>>>> which is what ndctl_test_init() validates.
>>>
>>> Isn't what modinfo lists also what modrobe loads?

<snip>

> modules are not loaded before the test.
> 
> Maybe something goes wrong with the test module build?
> 
> It is very fragile and requires complete kernel source for each
> configuration built. See below for the package
> 
> https://build.opensuse.org/package/show/home:michals/nfit_test
> 
> Attaching the log of test run which does not report any missing tools,
> only complains about nfit.ko being production.

I have attempted to fix few of the known issues in the first 3 patches 
of the series posted here.

https://patchwork.kernel.org/project/linux-nvdimm/list/?series=633103

> 
> Thanks
> 
> Michal