linux-kernel - Re: [PATCH v6 05/17] powerpc: define get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ilqtaiot.fsf@mpe.ellerman.id.au>
Date:   Thu, 28 Apr 2022 15:19:30 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        tglx@...utronix.de, arnd@...db.de
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH v6 05/17] powerpc: define get_cycles macro for
 arch-override

"Jason A. Donenfeld" <Jason@...c4.com> writes:
> PowerPC defines a get_cycles() function, but it forgot to do the usual
> `#define get_cycles get_cycles` dance, making it impossible for generic
> code to see if an arch-specific function was defined.
>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  arch/powerpc/include/asm/timex.h | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers

> diff --git a/arch/powerpc/include/asm/timex.h b/arch/powerpc/include/asm/timex.h
> index fa2e76e4093a..14b4489de52c 100644
> --- a/arch/powerpc/include/asm/timex.h
> +++ b/arch/powerpc/include/asm/timex.h
> @@ -19,6 +19,7 @@ static inline cycles_t get_cycles(void)
>  {
>  	return mftb();
>  }
> +#define get_cycles get_cycles
>  
>  #endif	/* __KERNEL__ */
>  #endif	/* _ASM_POWERPC_TIMEX_H */
> -- 
> 2.35.1