linux-kernel - Re: [PATCH v2] firmware_loader: use kernel credentials when reading firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+zpnLd7EJzutxcfFEoCjnG0_JhCFeyxYDtiEzaYL19rwtjBwA@mail.gmail.com>
Date:   Thu, 28 Apr 2022 15:46:29 +1000
From:   Thiébaud Weksteen <tweek@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Qian Cai <quic_qiancai@...cinc.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        Jeffrey Vander Stoep <jeffv@...gle.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Alistair Delva <adelva@...gle.com>,
        Adam Shih <adamshih@...gle.com>,
        SElinux list <selinux@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] firmware_loader: use kernel credentials when reading firmware

> Ugh, yeah, a put_cred() is not called after this.

Good catch, I wasn't aware that an extra call to put_cred was required here.

I'll send a new version for the patch. I'll update the commit log as
well, with the recommendation from Luis. Thanks.