[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <239ae645-7fb1-ca8c-1b37-2238313d6d1f@suse.com>
Date: Thu, 28 Apr 2022 09:06:27 +0200
From: Juergen Gross <jgross@...e.com>
To: Boris Ostrovsky <boris.ostrovsky@...cle.com>,
xen-devel@...ts.xenproject.org, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Stefano Stabellini <sstabellini@...nel.org>
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
On 21.04.22 22:56, Boris Ostrovsky wrote:
>
> On 4/21/22 4:40 AM, Juergen Gross wrote:
>> On 20.04.22 18:12, Boris Ostrovsky wrote:
>>> And also looking at invocations of scsiback_do_resp_with_sense() I think
>>> those may need to be adjusted as well.
>>
>> No, the invocations are fine, but scsiback_result() needs to pass through
>> the lowest 16 bits instead of only the lowest 8 bits of the result value.
>>
>
> What I was thinking was that this could use the reverse of
> XEN_VSCSIIF_RSLT_HOST(), i.e. something like
>
> #define RSLT_HOST_TO_XEN_VSCSIIF(x) ((x)<<16)
>
> to be explicit about namespaces.
I don't think this is needed.
> BTW, should scsiback_result() use XEN_VSCSIIF_RSLT_HOST() at the top?
Yes, I'll do that.
Juergen
Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)
Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)
Powered by blists - more mailing lists