linux-kernel - Re: [PATCH] dma-buf: add the name field to the table header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4e5bd41-df5b-bb65-b92f-47122d1e7738@amd.com>
Date:   Thu, 28 Apr 2022 10:03:07 +0200
From:   Christian König <christian.koenig@....com>
To:     Yuanzheng Song <songyuanzheng@...wei.com>, sumit.semwal@...aro.org,
        dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-buf: add the name field to the table header

Am 28.04.22 um 08:39 schrieb Yuanzheng Song:
> 'cat /sys/kernel/debug/dma_buf/bufinfo' will print the Dma-buf
> Objects' information when the CONFIG_DEBUG_FS=y.
> However, the printed table header information does not contain
> the name field. So we need to add the name field to the table
> header and use the '<none>' to replace the empty buf_obj->name.
>
> Signed-off-by: Yuanzheng Song <songyuanzheng@...wei.com>

Reviewed-by: Christian König <christian.koenig@....com>

Sumit do you want to push this or should I go ahead?

> ---
>   drivers/dma-buf/dma-buf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 79795857be3e..a2f9a1815e38 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1351,7 +1351,7 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused)
>   		return ret;
>   
>   	seq_puts(s, "\nDma-buf Objects:\n");
> -	seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\n",
> +	seq_printf(s, "%-8s\t%-8s\t%-8s\t%-8s\texp_name\t%-8s\tname\n",
>   		   "size", "flags", "mode", "count", "ino");
>   
>   	list_for_each_entry(buf_obj, &db_list.head, list_node) {
> @@ -1368,7 +1368,7 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused)
>   				file_count(buf_obj->file),
>   				buf_obj->exp_name,
>   				file_inode(buf_obj->file)->i_ino,
> -				buf_obj->name ?: "");
> +				buf_obj->name ?: "<none>");
>   		spin_unlock(&buf_obj->name_lock);
>   
>   		dma_resv_describe(buf_obj->resv, s);