linux-kernel - Re: [PATCH 1/2] seccomp: Use FIFO semantics to order notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220428080424.p3ltkcwtk3icvq6n@wittgenstein>
Date:   Thu, 28 Apr 2022 10:04:24 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Sargun Dhillon <sargun@...gun.me>
Cc:     Kees Cook <keescook@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Tycho Andersen <tycho@...ho.pizza>,
        Andy Lutomirski <luto@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH 1/2] seccomp: Use FIFO semantics to order notifications

On Wed, Apr 27, 2022 at 06:54:46PM -0700, Sargun Dhillon wrote:
> Previously, the seccomp notifier used LIFO semantics, where each
> notification would be added on top of the stack, and notifications
> were popped off the top of the stack. This could result one process
> that generates a large number of notifications preventing other
> notifications from being handled. This patch moves from LIFO (stack)
> semantics to FIFO (queue semantics).
> 
> Signed-off-by: Sargun Dhillon <sargun@...gun.me>
> ---

It has a minimal user-visible impact in a sense but I don't think it
should be an issue. Makes sense to me,
Reviewed-by: Christian Brauner (Microsoft) <brauner@...nel.org>