linux-kernel - Re: [PATCH v8] platform: x86: Add ChromeOS ACPI device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28534819-647e-1fef-2754-63aba75f821e@collabora.com>
Date:   Thu, 28 Apr 2022 13:12:19 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Benson Leung <bleung@...omium.org>
Cc:     usama.anjum@...labora.com,
        Collabora Kernel ML <kernel@...labora.com>,
        groeck@...omium.org, dtor@...omium.org,
        Len Brown <lenb@...nel.org>, gwendal@...omium.org,
        vbendeb@...omium.org, andy@...radead.org,
        Ayman Bagabas <ayman.bagabas@...il.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Blaž Hrastnik <blaz@...n.io>,
        Darren Hart <dvhart@...radead.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeremy Soller <jeremy@...tem76.com>,
        Mattias Jacobsson <2pi@....nu>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Rajat Jain <rajatja@...gle.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Enric Balletbo i Serra <eballetbo@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v8] platform: x86: Add ChromeOS ACPI device driver

Hi,

On 4/27/22 7:22 PM, Hans de Goede wrote:
> On 4/22/22 16:47, Muhammad Usama Anjum wrote:
>> Hi Hans,
>>
>> Can I add you as a maintainer of drivers/platform/x86/chromeos_acpi.c?
>> You already maintain some other drivers in this directory.
> If you want to rely on me as default/fallback maintainer
> for the new chromeos_acpi driver, then simply don't add
> a MAINTAINERS entry for this driver.
> 
> I'm the default maintainer for everything under
> drivers/platform/x86/ .
> 
> With that said:
> 
> 
>> On 4/18/22 10:57 PM, Muhammad Usama Anjum wrote:
>>> Hi Benson,
>>>
>>> We are very near to getting this patch in. I can see that you are
>>> maintaining Chrome Platform support. This driver is in
>>> drivers/platform/x86/chromeos_acpi.c. Can you maintain this driver as
>>> well? I'll add you to the maintainers.
> now that you mention it, moving this to drivers/platform/chrome/
> actually seems like the most sensible thing to do given that
> this is chrome specific platform code. So please move it
> there for the next version.
> 
This driver was added in platform/x86 as it is only x86 specific.
Definitely it makes more sense to move it to platform/chrome. I'll move it.

> Talking about the next version, please address all review
> remarks from Barnabás for the next version.
> 
After Greg's comment to define attributes at compile time, the driver
will change completely and way simpler.

> Regards,
> 
> Hans
> 
> 
> 

-- 
Muhammad Usama Anjum