linux-kernel - Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <262043e4-feee-5540-9a43-8871cb51764a@redhat.com>
Date:   Thu, 28 Apr 2022 10:13:28 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        linux-kernel@...r.kernel.org
Cc:     David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
        Lyude Paul <lyude@...hat.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>
Subject: Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV
 and DRM_DP_CEC

On 4/28/22 10:04, Thomas Zimmermann wrote:

[snip]

>>
>> Right. So giving even more thought to this, now I think that we should just include
>> drm_dp_aux_dev.o, drm_dp_cec.o (and probably drm_dp_aux_bus.o?) unconditionally to
>> drm_display_helper-$(CONFIG_DRM_DISPLAY_DP_HELPER).
>>
>> After all, these are not big objects and drm_display_helper can now be built as module.
>>
>> I don't see that much value to have separate user-configurable config options...
>>
> 
> I don't know the side effects of this. We're exporting another device 
> file after all.
> 
> For know I'd make them depend on DRM_DISPLAY_DP_HELPER. If someone 
> complains we can revert and fix the linker error by adding stub 
> functions for the missing symbols.
>

Ok, I'll just add the depends on then to fix the linking errors and then either
adding the stubs when disabled or just making it part of the DP_HELPER can be
done as a follow-up.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat