linux-kernel - Re: [PATCH v3 3/8] PCI: rcar-gen2: Add RZ/N1 SOCs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Apr 2022 11:19:50 +0200
From:   Herve Codina <herve.codina@...tlin.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Marek Vasut <marek.vasut+renesas@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>, linux-pci@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sergey Shtylyov <s.shtylyov@....ru>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Clement Leger <clement.leger@...tlin.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH v3 3/8] PCI: rcar-gen2: Add RZ/N1 SOCs support

Hi Bjorn,

On Fri, 22 Apr 2022 11:47:44 -0500
Bjorn Helgaas <helgaas@...nel.org> wrote:

> On Fri, Apr 22, 2022 at 02:08:45PM +0200, Herve Codina wrote:
> > Add Renesas RZ/N1 SOCs family support to the Renesas R-Car
> > gen2 PCI bridge driver.
> > The Renesas RZ/N1 SOCs internal PCI bridge is comptible with
> > the one available in the R-Car Gen2 family.
> > Tested with the RZ/N1D (R9A06G032) SOC.  
> 
> Nits (only address if you have some other reason to repost this
> series):
> 
>   - Subject claims this adds "support," which suggests that this adds
>     some piece of new functionality.  But it adds no new
>     functionality, it merely adds a new compatible string.  I would
>     say "Add RZ/N1 SOC compatible string"
> 
>   - Add blank lines between paragraphs
> 
>   - Rewrap paragraphs to fill 75 characters
> 
>   - s/comptible/compatible/
> 
>   - s/R-Car gen2/R-Car Gen2/ to write this consistently instead of
>     capitalizing "Gen2" sometimes but not others

I plan a v4 and so, I will take these points into account.

Thanks for the review.

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com