linux-kernel - Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Apr 2022 11:23:02 +0200
From:   Herve Codina <herve.codina@...tlin.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Marek Vasut <marek.vasut+renesas@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Geert Uytterhoeven" <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>, <linux-pci@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Clement Leger <clement.leger@...tlin.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Hi Sergey,

On Sat, 23 Apr 2022 19:41:09 +0300
Sergey Shtylyov <s.shtylyov@....ru> wrote:

> On 4/23/22 12:09 PM, Sergey Shtylyov wrote:
> 
> [...]
> >> Define the r9a06g032 generic part of the USB PHY device node.
> >>
> >> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> >> ---
> >>  arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
> >> index 33581f0c55c4..58af07eb75c9 100644
> >> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> >> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> >>  		clock-frequency = <0>;
> >>  	};
> >>  
> >> +	usbphy: usbphy {  
> > 
> >    I think the node name should be "usb-phy"...  
> 
>    It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-)

Will be changed in v4.

Thanks for pointing this.

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com