linux-kernel - Re: [PATCH v2] irq_work: Make irq_work_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmpdXfJswI9rlG3w@hirez.programming.kicks-ass.net>
Date:   Thu, 28 Apr 2022 11:24:45 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jun Miao <jun.miao@...el.com>
Cc:     elver@...gle.com, dvyukov@...gle.com, ryabinin.a.a@...il.com,
        bigeasy@...utronix.de, qiang1.zhang@...el.com,
        andreyknvl@...il.com, kasan-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH v2] irq_work: Make irq_work_queue_on() NMI-safe again

On Wed, Apr 27, 2022 at 09:55:49PM +0800, Jun Miao wrote:
> We should not put NMI unsafe code in irq_work_queue_on().

Why not, irq_work_queue_on() is not NMI safe. Only irq_work_queue() is.