linux-kernel - Re: [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ympsc5PG9YRZmJzG@smile.fi.intel.com>
Date:   Thu, 28 Apr 2022 13:29:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 1/4] platform/x86: pmc_atom: remove unused
 pmc_atom_write()

On Thu, Apr 28, 2022 at 02:24:27AM -0400, Paul Gortmaker wrote:
> This function isn't used anywhere in the driver or anywhere in tree.
> So remove it.  It can always be re-added if/when a use arises.

Can we first move the driver under intel subfolder and then update?

I have no strong opinion, but personally I would keep it (even unexported) just
for the sake of consistency. Up to Mark and Hans.

-- 
With Best Regards,
Andy Shevchenko