linux-kernel - [PATCH v2 0/2] usb: core: acpi: Rely on the sysdev pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Apr 2022 14:10:54 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Felipe Balbi <balbi@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 0/2] usb: core: acpi: Rely on the sysdev pointer

Hi,

I've added a comment in the first patch explaining that the sysdev
pointer is the host controller from firmware perspective like
requested by Andy. But please note that I did not make any comments
about the location of the sysdev ACPI companion in ACPI namespace on
purpose. We don't need to, and we actually can't make any assumptions
about that.

original cover letter:

Since we have that sysdev pointer, we need to use it also when
assigning the ACPI companion for the root hub. That should remove the
need to "manually" assign the ACPI companion to the controller device
in the xhci glue drivers like dwc3-host.c.

Assigning the ACPI companion in those glue drivers is very
problematic, because it screws up the fwnode->secondary pointer. But
as said, since we have that sysdev pointer, there is no need to
manually set it. sysdev pointer should always point to the correct
physical device from firmware PoW.

thanks,

Heikki Krogerus (2):
  usb: core: acpi: Use the sysdev pointer instead of controller device
  usb: dwc3: host: Stop setting the ACPI companion

 drivers/usb/core/usb-acpi.c | 7 +++++--
 drivers/usb/dwc3/host.c     | 2 --
 2 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.35.1